search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

Determine origin #59

Closed sirsean closed 8 years ago

sirsean commented 8 years ago

Determine the origin of a message based on what it looks like.

This assumes that it receives parsed JSON from syslog-ng, and then uses core.match to pattern match its structure.

We've also tied this into the Onyx catalog, and shifted around the BS MySQL stuff so we store the origin in the table. (This is done stupidly, but we're just going to throw it all away when we drop MySQL anyway.)

codecov-io commented 8 years ago

Current coverage is 67.01%

Merging #59 into master will increase coverage by +2.57% as of 4cad593

@@            master     #59   diff @@
======================================
  Files           15      15       
  Stmts          180     191    +11
  Branches         2       3     +1
  Methods          0       0       
======================================
+ Hit            116     128    +12
- Partial          2       3     +1
+ Missed          62      60     -2

Review entire Coverage Diff as of 4cad593

Powered by Codecov. Updated on successful CI builds.

lvh commented 8 years ago

Overall this PR looks pretty great, and I'm happy to see how quickly you've been able to pick up Clojure and be productive with it. There's a bunch of comments still open that we should probably close out first, but overall I'm really happy about that PR :)

lvh commented 8 years ago

Would you mind merging forward/rebasing so we start seeing some data on how much the newly-enabled container infra affects build times?

lvh commented 8 years ago

Once this gets converted back to cheshire I'm happy to merge this; everything else I have are just indentation nitpicks.