search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

Add docker-compose to Travis #62

Closed lvh closed 8 years ago

lvh commented 8 years ago

Closes #60.

lvh commented 8 years ago

/usr/local/lib/python2.7/dist-packages/pip-7.1.2-py2.7.egg/pip/vendor/requests/packages/urllib3/util/ssl.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.

I'm pretty happy that we get an exception about that now :D

lvh commented 8 years ago

I typed the letters PYTHONWARNINGS=ignore into a commit so I'd like @reaperhulk to sign off :)

codecov-io commented 8 years ago

Current coverage is 67.01%

Merging #62 into master will not affect coverage as of c95777d

@@            master     #62   diff @@
======================================
  Files           15      15       
  Stmts          191     191       
  Branches         3       3       
  Methods          0       0       
======================================
  Hit            128     128       
  Partial          3       3       
  Missed          60      60

Review entire Coverage Diff as of c95777d

Powered by Codecov. Updated on successful CI builds.

lvh commented 8 years ago

Except of course docker the service is unavailable on the old container infra, so now I'm at:

$ sudo service docker start

docker: unrecognized service
lvh commented 8 years ago

Unfortunately, it looks like Travis still doesn't support docker-in-docker on the container infra, and so we have to move back to GCE infrastructure (and slow builds) for the time being. cc @reaperhulk to sign off on this actually being true.

lvh commented 8 years ago

cc @sirsean -- that's not to say that your opinion isn't appreciated here; I'm just pinging @reaperhulk because he's had some experience with Travis CI :)

sirsean commented 8 years ago

Haha I'd defer to @reaperhulk on that too. He has way more insight into Travis CI than I do.

reaperhulk commented 8 years ago

That is correct. Docker-in-docker is not a thing the container infra supports at this time (although docker itself is entirely capable of it).

lvh commented 8 years ago

OK, since this appears to be the only way to get a working docker + working builds, it seems like this ought to be merged.

ehashman commented 8 years ago

Cool, LGTM.

Do you want to keep all that history for this two-line change or is it okay to squash those commits before I merge?

lvh commented 8 years ago

I think the struggle can be instructive, yes :) Thanks for the review!