search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

Add ClojureScript testing infrastructure based on doo + karma #69

Closed lvh closed 8 years ago

lvh commented 8 years ago

This builds on #68. This is currently a WIP; it is only open so that Travis builds stuff for me on occasion.

codecov-io commented 8 years ago

Current coverage is 67.01%

Merging #69 into master will not affect coverage as of 83e90fd

@@            master     #69   diff @@
======================================
  Files           15      15       
  Stmts          191     191       
  Branches         3       3       
  Methods          0       0       
======================================
  Hit            128     128       
  Partial          3       3       
  Missed          60      60

Review entire Coverage Diff as of 83e90fd

Powered by Codecov. Updated on successful CI builds.

lvh commented 8 years ago

I have confirmed in https://travis-ci.org/RackSec/desdemona/jobs/114371032 that a failed doo test will fail the CI.

lvh commented 8 years ago

Could someone please review this? I'm pretty sure it's ready to merge.

sirsean commented 8 years ago

Does this need master merged into it? There are some "changed" the diff is showing that I think are already in master.

lvh commented 8 years ago

Merged forward; diff looks better now :)

sirsean commented 8 years ago

Sure does. :+1:

(I have no experience with ClojureScript or doo, etc, but assuming those are things that work, and CI appears to confirm that, then this looks good to me.)