search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

Add metrics coverage #74

Closed lvh closed 8 years ago

lvh commented 8 years ago

This should help knock our coverage up a few percentage points.

lvh commented 8 years ago

Refs #4, #6.

codecov-io commented 8 years ago

Current coverage is 69.51%

Merging #74 into master will increase coverage by +2.50% as of fdc8cc9

@@            master     #74   diff @@
======================================
  Files           15      15       
  Stmts          191     187     -4
  Branches         3       3       
  Methods          0       0       
======================================
+ Hit            128     130     +2
  Partial          3       3       
+ Missed          60      54     -6

Review entire Coverage Diff as of fdc8cc9

Powered by Codecov. Updated on successful CI builds.

lvh commented 8 years ago

I could have gamed the numbers a little more by not rewriting that fn with the let (since that reduced the line count), but I opted against that ;)

sirsean commented 8 years ago

The function looks a lot better now.