search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

Can successfully docker build now, with npm installed in the image #78

Closed sirsean closed 8 years ago

sirsean commented 8 years ago

Resolves: https://github.com/RackSec/desdemona/issues/76

This is solved the dumb way, just by installing npm. I couldn't figure out how to configure project.clj such that npm isn't required to build the jar.

lvh commented 8 years ago

There should be a ticket for having the build container separate from the run container.

lvh commented 8 years ago

This looks good to me assuming CI passes.

sirsean commented 8 years ago

Given that Docker isn't gating in CI I'd be surprised if it failed. ;-p

lvh commented 8 years ago

Hehe, yeah. By "passes" I mean "goes back to failing because of #45".

codecov-io commented 8 years ago

Current coverage is 69.51%

Merging #78 into master will not affect coverage as of d1e4070

@@            master     #78   diff @@
======================================
  Files           15      15       
  Stmts          187     187       
  Branches         3       3       
  Methods          0       0       
======================================
  Hit            130     130       
  Partial          3       3       
  Missed          54      54

Review entire Coverage Diff as of d1e4070

Powered by Codecov. Updated on successful CI builds.

lvh commented 8 years ago

This looks like it's now fixed. Once you've written the other issue out, I think this is good to go :)