search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

Adding ring-handler pointing all requests at single page #86

Closed smogg closed 8 years ago

codecov-io commented 8 years ago

Current coverage is 80.09%

Merging #86 into master will decrease coverage by -0.43% as of c5dc124

@@            master     #86   diff @@
======================================
  Files           16      17     +1
  Stmts          190     201    +11
  Branches         3       6     +3
  Methods          0       0       
======================================
+ Hit            153     161     +8
- Partial          3       6     +3
  Missed          34      34

Review entire Coverage Diff as of c5dc124

Powered by Codecov. Updated on successful CI builds.

lvh commented 8 years ago

This looks fine to me as long as you add test coverage :) Fortunately ring handler functions are easy to test: just call it and see what happens...

lvh commented 8 years ago

The reduced coverage is a bug; the macros are used correctly; they just expand to two branches, one of which isn't covered.