search

RackSec / desdemona

Data-backed security operations
Eclipse Public License 1.0
2 stars 7 forks source link

Simplify Dockerfile #95

Closed lvh closed 8 years ago

lvh commented 8 years ago

This started out as a small experiment that ended up being a huge pain in the neck; but I did learn a bunch of stuff...

Since the Aeron media driver and the production peers are never launched separately, this unifies the run script.

lvh commented 8 years ago

Once this is merged, I'll move the docker-compose.yml file to the new version 2 syntax, which lets us enable volumes, which lets us have much faster builds (at least locally, and on Jenkins in the future).

codecov-io commented 8 years ago

Current coverage is 80.09%

Merging #95 into master will not affect coverage as of afae4c4

@@            master     #95   diff @@
======================================
  Files           17      17       
  Stmts          201     201       
  Branches         6       6       
  Methods          0       0       
======================================
  Hit            161     161       
  Partial          6       6       
  Missed          34      34

Review entire Coverage Diff as of afae4c4

Powered by Codecov. Updated on successful CI builds.

lvh commented 8 years ago

I think I've figured out the Chesterton's gate of copying project.clj over first: it means not having to completely rebuild the container when all has changed is your code. However, I think the better solution for that is just to cache debs + ~/.m2.