search

RadBuilder / EmojiChat

A simple, configurable, opensource plugin that adds emojis to your chat!
https://emojichat.radbuilder.net/
MIT License
41 stars 29 forks source link

EmojiChat breaks http:// & https:// hyperlink chat output. #18

Open mibby opened 4 years ago

mibby commented 4 years ago

EmojiChat v1.8.3

Typing a link in chat such as https://www.example.com replaces the text to https\://www.example.com.

https://github.com/RadBuilder/EmojiChat/blob/c1791262e4c01f4cb68e9377329535d4952a2370/plugin/src/main/java/io/github/radbuilder/emojichat/utils/EmojiHandler.java#L299

RadBuilder commented 4 years ago

That line of code referenced is supposed to replace the http:// and https:// to escape the :/ emoji. I'll have to test this to see if it's an issue.

mibby commented 4 years ago

I just commented out that line for the time being to fix the issue, but did confirm links were adding \ in http:// due to it.

I removed the :/ emoji shortcut awhile ago since links were being pasted with an emoji in them, it wasn't actually stripping the emoji from it.

RadBuilder commented 4 years ago

Does keeping the :/ emoji shortcut fix the issue?

mibby commented 4 years ago

I don't recall, sorry. When I had the :/ emoji shortcut, links in chat had an emoji in the url address. So it wasn't even stripping the emoji. It's what prompted me to remove the shortcut in the first place, thus discovering this issue.