Move plugin to visitor API

RadValentin / postcss-prefix-selector

Prefix all CSS rules with a selector

MIT License

165 stars 16 forks source link

Move plugin to visitor API #93

Closed TheSeally closed 3 years ago

TheSeally commented 3 years ago

Since postcss-nested moved to visitor API (in version 5.0.2) there is a problem with correctness of processing nested rules using this plugin. This problem discussed in more details in https://github.com/postcss/postcss/issues/1611#issue-934800901

So I tried to fix it by moving your plugin to visitor API too and this fixed problem. All test in repo was passed but maybe you have additional checks

RadValentin commented 3 years ago

Looks good, thanks for contributing! It will take a few days until I can push out a new version as I'm busy with exams ATM and I'd like to add at least one test around nesting.

RadValentin commented 3 years ago

Nvm the wait, I went ahead an published a new version 1.11.0 with the fix 🚀

Bdg0o commented 3 years ago

Thanks guys !

RadValentin commented 3 years ago

I jumped the gun on this one 😞 and didn't realise it was a breaking change (see #94). I'll do a full upgrade of the plugin to support PostCSS 8 in #95 and release it as v2.0.0