search

RadarCOVID / radar-covid-android

Native Android app using DP^3T Android sdk to handle Exposure Notifications API from Google
Mozilla Public License 2.0
382 stars 84 forks source link

Fix workflow. Now is triggered when a push or PR points to master. 🔑 #17

Closed dagonco closed 2 years ago

dagonco commented 3 years ago

Hi! I did some improvements in this file to run the test suite in every commit or pull request that points to master. So you could check before is merged if something is broken.

Why master? Because the file makes reference to develop, branch who doesn't exists. In case that you'll create it, we can go backwards easily.

Also, I change gradle task test → testProReleaseUnitTest. The main reason is that by not having different code for each flavor, it is not necessary to run the suite N times. So, production flavor in release is the ideal one!

Hope you like it! And, hey, nice work. Congrats. 😇

mercuriete commented 3 years ago

In my opinion it will be better to don't restrict any branch

on: [push, pull_request]

with that change you wont break the pipeline when the project changes the main branch from master to whatever (main)

avecina commented 3 years ago

This could be a good improvement but we will take a closer look at this. Thanks.