search

Radarr / Radarr

Movie organizer/manager for usenet and torrent users.
https://radarr.video
GNU General Public License v3.0
10.13k stars 988 forks source link

Ability to specify Base URL with an environment variable #3587

Closed StFS closed 5 years ago

StFS commented 5 years ago

I’m putting together a comprehensive set of services for my HTPC needs, these include Sonarr, Radarr, Deluge and more. I’m doing this using docker-compose.

As I’m starting multiple services that all have web UIs, I want to start an nginx reverse proxy as well that would simplify the way these web UIs are accessed, so instead of htpc-server:8989 for sonarr and htpc-server:7878 for radarr, I could simply go to htpc-server/sonarr and htpcs-server/radarr.

However, that means that I would have to configure the URL Base in the configuration file before starting the radarr container. This is a bit of a hazzle (having to do some config file editing magic every time before the container start to make sure that the config option in config.xml matches the correct base url).

A much simpler solution would be if I could start the container up with an environment variable that specifies the URL base string.

I would imagine that this would be as simple as “if environment variable RADARR_URL_BASE is set, use that, otherwise fall back to old behavior of reading the config file”.

issue-label-bot[bot] commented 5 years ago

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.71. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

fryfrog commented 5 years ago

You don't really need a url base w/ reverse proxy, I'd suggest ignoring it.

But maybe if you can convince Sonarr of the usefulness of this option, it could get merged to Radarr and Lidarr.

I'd actually suggest a -option like we have for -data.

You could also just fork the Docker images and do it yourself, a sed one liner should accomplish it. Maybe @hotio or @binhex would even consider a pull request adding it.