Moving movies without moving files within same root doesn't update folder/file naming convention but does when selecting new root

[edrock200]

Is there an existing issue for this?

• [X] I have searched the existing open and closed issues

Current Behavior

I'm not sure if this is a bug or intended behavior however if I update the movie folder naming convention, then select movies in a specific root, then set them to move to the same root:

1. If I select yes to move files, it will properly "move" the movies into new folders of the same root using the new naming convention.
2. If I say I will move the files myself, it will not update the paths to the new naming convention if moving from same root to same root. But will if moving to different root.

Expected Behavior

Both options update path to new naming convention.

Steps To Reproduce

1. Change your folder naming convention so it differs from currently loaded movies
2. Go to movie list
3. Click mass editor
4. Select a movie
5. Set it to move to same root
6. Select "I will move myself" when prompted

To see desired outcome repeat above steps but select a different root at step 5.

Environment

- OS: Ubuntu 18.04 (docker container)
- Radarr: 5.0.0.7947
- Docker Install: linuxserver 
- Using Reverse Proxy: yes nginx with ssl
- Browser: chrome latest prod
- Database: Sqlite 3.41.2 Migration 232

What branch are you running?

Nightly

Trace Logs? Not Optional

Attached below radarr.trace.txt

Trace Logs have been provided as applicable. Reports will be closed if the required logs are not provided.

• [X] I have read and followed the steps in the wiki link above and provided the required trace logs - the logs contain trace - that are relevant and show this issue.

[bakerboy448]

• the destination path is only built (rebuilt) if Radarr is moving the movies https://github.com/Radarr/Radarr/blob/0f699a01f705206ab3cf3503c56ac4d1b03c1947/src/NzbDrone.Core/Movies/MoveMovieService.cs#L103

• otherwise it simply updates the root folder for the movie without updating the folder name https://github.com/Radarr/Radarr/blob/0f699a01f705206ab3cf3503c56ac4d1b03c1947/src/Radarr.Api.V3/Movies/MovieEditorController.cs#L50-L58 https://github.com/Radarr/Radarr/blob/0f699a01f705206ab3cf3503c56ac4d1b03c1947/src/Radarr.Api.V3/Movies/MovieEditorController.cs#L80-L89

• not a bug

• could be considered a feature request; defer to @Qstick to reopen if so, but it doesn't seem like it'd make sense for radarr to change the assigned movie folder name if it is not doing the renaming for it....would rely on the user to then ensure they rename the folders to follow radarr's new naming which seems like support headaches

[edrock200]

Interesting as it does update when updating to a new root, but not moving files, just not same root. Either way, appreciate the quick response, thanks!

[bakerboy448]

hmmm - so Root A to Root B without move files the name will update; Root B to Root B without move files the name will not update?

[edrock200]

hmmm - so Root A to Root B without move files the name will update; Root B to Root B without move files the name will not update?

Correct.

[bakerboy448]

ah yeah; that's weird and should at least be consistent one way or another then; can you tweak the title accordingly please

[edrock200]

Sure thing