search

RadeonOpenCompute / ROCm_Documentation

Legacy ROCm Software Platform Documentation
http://rocm.docs.amd.com
112 stars 92 forks source link

Replacing all uses of apt-key with gpg #145

Closed dmikushin closed 2 years ago

dmikushin commented 2 years ago

Replacing all uses of apt-key with gpg, using Docker installation guide as an reference example. By doing this, we acknowledge the deprecation of apt-key utility for this purpose:

Use of apt-key is deprecated, except for the use of apt-key del in maintainer scripts to remove existing keys from the main keyring.

Rmalavally commented 2 years ago

@dmikushin Thank you for the pull request. We appreciate your interest in improving ROCm documentation.

Please note that the official ROCm documentation will be updated for the 22.04 version in a future release while providing support for older releases.

We are unable to accept the pull request at this time.

ROCm Documentation Team

dmikushin commented 2 years ago

Hi @Rmalavally

Please note that the official ROCm documentation will be updated for the 22.04 version in a future release while providing support for older releases.

I'm not sure what you mean by this. Do you want to keep the apt-key and gpg mess for older releases, and fix it just for the 22.04 release?

Rmalavally commented 2 years ago

@dmikushin

The intent is to display a warning for older releases while we transition users to the new 'apt-key' mechanism. This is to ensure the existing users are not inconvenienced.

@zhang2amd

dmikushin commented 2 years ago

Let's take Docker as a credible example of a well-written installation guide. They do not differentiate the key importing practice for their releases. Their installation instruction is universal. That's why I believe by retroactively aligning our older releases with the best practices we actually remove possible inconvenience for the users.

dmikushin commented 2 years ago

Another credible example could be CMake: https://apt.kitware.com/ You can see that Ubuntu 16.04, 18.04 and 20.04 key management appears exactly the same way, side by side on a single page.

Rmalavally commented 2 years ago

@dmikushin Thank you for the links and recommendations. You are correct about Docker and Kitware installation instructions; they are good examples of the installation guide documentation.

We will review your suggestions with the internal teams and update the ROCm documentation for Ubuntu 22.04 accordingly.

ROCm Documentation Team