search

RadiCards / radi.cards

NFT eCards for greater fun and greater good. All income goes to charities working to promote Internet freedom and environmental rights. ♣️
http://radi.cards
MIT License
23 stars 7 forks source link

Notification on claimable gift screen #72

Open Lililashka opened 5 years ago

Lililashka commented 5 years ago

When viewing this screen from a non-web3 browser, user doesn’t get a helpful response once clicked on ‘claim gift’ button.

Reproduce this bug:

  1. Click on a claim link
  2. Open up a new screen with card preview and button ‘claim gift’
  3. Click on ‘claim gift’ button
  4. Nothing happens

Suggested solution:

  1. Add a pop-up note once users from non-web3 browser click claim gift button. “Oops! You can only claim gift using web3 browser. Install MetaMask, ImToken to get started.”

I’ll create this mock-up in figma and share it.

chrismaree commented 5 years ago

cool, thanks @Lililashka. I think this is due to portis providing a web3 client but if you dont create an account there is no unlocked wallet. this links to the other issue on defensive error handeling

seichris commented 5 years ago

made designs for all situations, with and without portis https://github.com/RadiCards/radi.cards/issues/59. probably they could help

seichris commented 5 years ago

Implemented this for now. Would disable the portis popup cause its still buggy (https://github.com/RadiCards/radi.cards/issues/73):

photo5384482065728252523