search

RadiantLabs / modeling-api-docs

Official Modeling API documentation
0 stars 1 forks source link

Use dual fuel for examples #11

Closed kellyatradiantlabs closed 10 months ago

jefffriesen commented 1 year ago

@kellyatradiantlabs isn't there more than 1 fixture that we are using for examples? Or are all requests returning the same one?

kellyatradiantlabs commented 1 year ago

@jefffriesen I am still working on other commits! There are more pages to edit. I might have marked the status or not done this right. Still getting the hang of the github workflow...

jefffriesen commented 1 year ago

@kellyatradiantlabs I think you did it right and I jumped the starting gun. It's in draft mode and you didn't assign a reviewer. Perfect.

kellyatradiantlabs commented 1 year ago

@joshuamzm everything has been updated aside from docs/source/examples/response/timelines/post/extensive_inputs.json. Something else has come up that I need to address with NYSERDA. Can you review what I've done here and merge? I'll circle back to updating that last example within the next week or so.

joshuamzm commented 1 year ago

@joshuamzm everything has been updated aside from docs/source/examples/response/timelines/post/extensive_inputs.json. Something else has come up that I need to address with NYSERDA. Can you review what I've done here and merge? I'll circle back to updating that last example within the next week or so.

@kellyatradiantlabs I've looked closely at your new changes. What drew my attention was the missing fields in the air distribution system and ducts from the extensive inputs requests example. I wrote down more details on that in a separate comment. Let me know if I need to make changes to the schema, most likely yes, but I'd like to have your input before proceeding.

kellyatradiantlabs commented 10 months ago

@joshuamzm I just noticed that this PR never got merged. Do you recall if any additional revisions need to be made?

joshuamzm commented 10 months ago

@kellyatradiantlabs Oh my! I completely overlooked this repository. I think no more revisions are needed for this PR. I'll merge right away.