search

RadiantLabs / modeling-api-docs

Official Modeling API documentation
0 stars 1 forks source link

Add validation tables #7

Closed kellyatradiantlabs closed 1 year ago

joshuamzm commented 1 year ago

@kellyatradiantlabs I've just seen this PR. Are you planning to add more content, or should I start reviewing it and hopefully merging soon?

kellyatradiantlabs commented 1 year ago

@joshuamzm this is ready for your review! In the future, should I ping you with a comment to let you know?

joshuamzm commented 1 year ago

@kellyatradiantlabs You can add me as a reviewer here, so I get notifications automatically. Also, I'll see my list of pending PRs to review not empty, so I can make sure I don't miss a thing.

image

For the fixtures and the later changes to the docs, it was on me I didn't follow up properly. And now that we have finally deployed fixtures, I looked back to what was still open or pending to merge. I proceed to review then.

joshuamzm commented 1 year ago

@kellyatradiantlabs I found the documentation talking about named footnotes here: https://sphinx-rtd-theme.readthedocs.io/en/stable/demo/demo.html#footnotes

Can you take a look? You'll need also to look at the source file of that page, but I don't remember where to find it. If I see it, I'll paste it back in this thread.

joshuamzm commented 1 year ago

@kellyatradiantlabs Here's the source for that page: https://raw.githubusercontent.com/readthedocs/sphinx_rtd_theme/9899ee4ee2f547f81e51297dc12317f018e62fdd/docs/demo/demo.rst

I attach a screenshot of that piece:

image