search

Radiation-Transport / iWW-GVR

A tool to manipulate MCNP weight window (WW) and to generate Global Variance Reduction (GVR) parameters
Other
7 stars 7 forks source link

Vtk fix #28

Closed rorni closed 9 months ago

rorni commented 1 year ago

I have met several minor bugs during my use of iWW-GWR and here I suggest a solution to fix them.

  1. When weight window data is saved to VTK, data axes are stored in a wrong order. It is illustrated on the screenshots below. The upper figure shows the vertical cross-section of weight-windows generated by the original code (however, data order in MCNP WW file is correct). So I suggest to swap x and z axes during data export to VTK format. The result after axes swap is shown on the bottom figure. axis_diff_before axis_diff_after

  2. Mesh location both in VTK and WW is shifted to the origin, at least for cartesian coordinate system. The error is introduced during meshtal file reading. When I fixed mesh values in WW file manually, all readings and writings were correct. The figure below shows by solid color WW mesh, and meshtally by wireframe. To fix this origin is not subtracted from mesh bin boundaries any more. mesh_location_diff

  3. Minor fixes in README and .gitignore.

AlvaroCubi commented 9 months ago

Thank you very much for noticing and fixing these problems.