Radiicall / jellyfin-rpc

Displays the content you're currently watching on Discord!
GNU General Public License v3.0
238 stars 18 forks source link

Hide Movie Genres #120

Closed AkikoKumagara closed 4 months ago

AkikoKumagara commented 5 months ago

Is there an existing issue for this?

Is your feature request related to a problem? Please describe

Yes, movie genres are treated the same way as music artists, which doesn't make a ton of sense to me. As such there's no way to disable them from displaying them that I can see. I'm hoping this isn't something at the fault of Jellyfin itself, but I suppose that's possible.

image

Describe the solution you'd like

Ability to hide movie genres from displaying; perhaps making them work the same way as music genres, if possible. Thanks for your hard work in maintaining and improving this 🙇‍♀️

Describe alternatives you've considered

No response

Additional context

No response

Radiicall commented 4 months ago

I know this issue has been open for a while and it will probably stay open for a while longer, im working on a total refactor which should in theory make implementing new features easier

AkikoKumagara commented 4 months ago

I know this issue has been open for a while and it will probably stay open for a while longer, im working on a total refactor which should in theory make implementing new features easier

That's ok. Thanks for the update. Grateful for what you do here.

Radiicall commented 4 months ago

image are you thinking something customizable like this? It works in the same way as the music config.

    "music": {
      "display": [
        "year",
        "album",
        "genres"
      ],
      "separator": null
    },
    "movies": {
      "display": [
        "year",
        "critic-score",
        "community-score",
        "genres"
      ],
      "separator": null
    },
AkikoKumagara commented 4 months ago

Oh, that's awesome.

Radiicall commented 4 months ago

If you want to test this functionality then you can download the latest artifact from the bottom of this page

Radiicall commented 4 months ago

Fixed in #125

AkikoKumagara commented 4 months ago

Fixed in #125

I'm trying on Windows with the new release and this is the only output with no Rich Presence display? image

Config looks like this: { "jellyfin": { "url": "http://xxxxxxxxxxxxxxxxx", "api_key": "xxxxxxxxxxxxxxxxxxxxx", "username": [ "XXXXX" ], "movies": { "display": [], "separator": "-" }, "music": { "display": [], "separator": "—" }, "blacklist": null, "self_signed_cert": null }, "discord": { "show_paused": false, "application_id": "XXXXXXXXXXXXXX", "buttons": [ { "name": "The Bear's Den", "url": "https://thebearsden.live" }, { "name": "dynamic", "url": "dynamic" } ] }, "imgur": { "client_id": "XXXXXXXXXXXXX" }, "images": { "enable_images": true, "imgur_images": true } } Put x's in place of sensitive data. I'm not sure what's going on. The same config works on the previous version fine. Am I missing something here?