Radiicall / jellyfin-rpc

Displays the content you're currently watching on Discord!
GNU General Public License v3.0
214 stars 13 forks source link

Support for changing activity type for diffent types of media #130

Open piplup55 opened 1 month ago

piplup55 commented 1 month ago

Is there an existing issue for this?

Is your feature request related to a problem? Please describe

there not really a problem, just a suggestion since discord now exposes the WATCHING, LISTENING TO, Competing in https://x.com/advaithj1/status/1816655583107510517

Describe the solution you'd like

having a config option for the type of activity you want to use maybe it could be per media type, per media type would be really helpful if you use jellyfin for music aswell as media example global:

  "discord": {
    "buttons": [{ }],
    "activity": "WATCHING"
  }

example per media:

    "music": {
      "display": ["album", "year"],
      "separator": "-"
       "activity": "LISTENING"
    }

Describe alternatives you've considered

maybe it could be a mix of both so you have a global type that can be overwritten by something like music

Additional context

No response

Radiicall commented 1 month ago

I'll check the discord api and then maybe send a feature request to the discord-rich-presence library im using

Radiicall commented 1 month ago

I tested this locally and sent a PR to the discord-rich-presence library, its cool that they finally added this! I've gotten so many issues about it

Radiicall commented 1 month ago

Also i probably wont implement changing it but i will make it "Watching Jellyfin" and "Listening to Jellyfin", for books i might keep it as playing but im not sure yet

piplup55 commented 1 month ago

Also i probably wont implement changing it

yeah that's fair, it was just an afterthought i had when i was going to make the FR, the way you want to do it actually does make more sense

Radiicall commented 1 month ago

After doing some testing i think this still needs to wait, timestamps dont seem to be working, if you know of any FOSS projects that have working timestamps when showing as "Listening to", "Competing in" or "Watching" then please send me a link so i can take a look

piplup55 commented 1 month ago

looks like it's bugged timestamps get ignored when setting the type to listening or watching

Radiicall commented 1 month ago

Yeah, it shows up on at least earlier versions of mobile discord, my phone is on 212.11 for instance but on desktop it doesnt work at all, guess we just have to wait and see if this is intended or if it will be fixed

Radiicall commented 1 month ago

https://github.com/vionya/discord-rich-presence/pull/40 here's the PR i submitted to upstream and it has some example images

Radiicall commented 1 month ago

I made a test version of jellyfin-rpc with this feature here

XDark187 commented 1 month ago

I've been using Vencord for a while with this plugin that allows replacing the activity with watching/streaming/competing etc.

Timestamps seems to be an issue with discord as the author of the plugin stated:

"ActivityTypes other than Playing will only show timestamps on mobile. It's a Discord issue."

The plugin has a cool toggle where you can swap presence name and details so it shows as "watching {movie name}" instead of "watching jellyfin". having an option to toggle this would be cool too.

image

Radiicall commented 1 month ago

I dont think swapping those two is something you can do through normal means, let me know if another project is doing that without modifying the client though and ill take a look at it

Radiicall commented 1 month ago

my fork got merged into https://github.com/vionya/discord-rich-presence, now all we need is for discord to make timestamps work again

Radiicall commented 6 days ago

Timestamps are sorta working but just the wrong way thanks to a discord update.. I hope they fix it and doesnt make the new way of not being able to specify start or end time permanent