RadioAstronomySoftwareGroup / pyradiosky

Python objects and interfaces for representing diffuse, extended and compact astrophysical radio sources
https://pyradiosky.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
14 stars 5 forks source link

Add allowed_failures parameter to SkyModel.__eq__ to match UVBase #192

Closed bhazelton closed 2 years ago

bhazelton commented 2 years ago

Description

Add support for the allowed_failures parameter in SkyModel.__eq__ to match the parameter added to pyuvdata.UVBase.__eq__ in version 2.2.1.

Motivation and Context

Checklists:

Bug Fix Checklist:

codecov[bot] commented 2 years ago

Codecov Report

Base: 99.67% // Head: 99.81% // Increases project coverage by +0.13% :tada:

Coverage data is based on head (5656f94) compared to base (54e121b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #192 +/- ## ========================================== + Coverage 99.67% 99.81% +0.13% ========================================== Files 6 5 -1 Lines 2165 2157 -8 ========================================== - Hits 2158 2153 -5 + Misses 7 4 -3 ``` | [Impacted Files](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyradiosky/pull/192?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup) | Coverage Δ | | |---|---|---| | [pyradiosky/skymodel.py](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyradiosky/pull/192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHlyYWRpb3NreS9za3ltb2RlbC5weQ==) | `99.79% <100.00%> (ø)` | | | [pyradiosky/\_\_init\_\_.py](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyradiosky/pull/192/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHlyYWRpb3NreS9fX2luaXRfXy5weQ==) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.