RadioAstronomySoftwareGroup / pyradiosky

Python objects and interfaces for representing diffuse, extended and compact astrophysical radio sources
https://pyradiosky.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
14 stars 5 forks source link

fix bug with pyuvdata PR #197

Closed bhazelton closed 1 year ago

bhazelton commented 1 year ago

Description

Fix a bug when using the branch this in pyuvdata PR: https://github.com/RadioAstronomySoftwareGroup/pyuvdata/pull/1252

The problem is that PR added more handling for a silent keyword in the parameter __eq__ method which breaks pyradiosky without this PR.

Motivation and Context

Checklists:

Bug Fix Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Base: 99.67% // Head: 99.67% // No change to project coverage :thumbsup:

Coverage data is based on head (21d55f3) compared to base (cb2ee30). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #197 +/- ## ======================================= Coverage 99.67% 99.67% ======================================= Files 6 6 Lines 2176 2176 ======================================= Hits 2169 2169 Misses 7 7 ``` | [Impacted Files](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyradiosky/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup) | Coverage Δ | | |---|---|---| | [pyradiosky/skymodel.py](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyradiosky/pull/197?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHlyYWRpb3NreS9za3ltb2RlbC5weQ==) | `99.79% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mkolopanis commented 1 year ago

I'm a little confused about the first comment, does this pug only exist once that PR is merged? Should we wait on this?

bhazelton commented 1 year ago

This fix got rolled into #199