Closed bhazelton closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
f9b8675
) to head (5857afd
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@aelanman We'd like your comments on this, you're listed as an author :)
Astropy 6.1 dropped a couple days ago and some new warnings are being generated. I fixed a couple of things in our tests (no non-test code needed to be modified), but most of the warnings are coming from lunarsky, tracked in an issue here: https://github.com/aelanman/lunarsky/issues/27.
Oh, yes. There's another transient issue I haven't run down where sometimes on mac builds in the install step setuptools_scm can't find git. Which makes no sense because the repo was cloned with git. This is occasionally seen in other repos too. For now I'll just re-run but long term we need to figure it out.
Right, the warning test failures are due to the new astropy warnings in lunarsky. They won't go away on a re-run but I'm hesitant to pin astropy because of warnings.
I re-ran until only the warnings tests were failing, then merged.
Description
Preparation to submit to JOSS. The compiled paper draft can be seen as an artifact on the paper_draft workflow under Actions.
Motivation and Context
Checklists:
Documentation Change Checklist: