RadioAstronomySoftwareGroup / pyradiosky

Python objects and interfaces for representing diffuse, extended and compact astrophysical radio sources
https://pyradiosky.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
15 stars 5 forks source link

JOSS paper #231

Closed bhazelton closed 5 months ago

bhazelton commented 9 months ago

Description

Preparation to submit to JOSS. The compiled paper draft can be seen as an artifact on the paper_draft workflow under Actions.

Motivation and Context

Checklists:

Documentation Change Checklist:

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f9b8675) to head (5857afd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #231 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 2134 2134 Branches 608 608 ========================================= Hits 2134 2134 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bhazelton commented 9 months ago

@aelanman We'd like your comments on this, you're listed as an author :)

bhazelton commented 5 months ago

Astropy 6.1 dropped a couple days ago and some new warnings are being generated. I fixed a couple of things in our tests (no non-test code needed to be modified), but most of the warnings are coming from lunarsky, tracked in an issue here: https://github.com/aelanman/lunarsky/issues/27.

bhazelton commented 5 months ago

Oh, yes. There's another transient issue I haven't run down where sometimes on mac builds in the install step setuptools_scm can't find git. Which makes no sense because the repo was cloned with git. This is occasionally seen in other repos too. For now I'll just re-run but long term we need to figure it out.

bhazelton commented 5 months ago

Right, the warning test failures are due to the new astropy warnings in lunarsky. They won't go away on a re-run but I'm hesitant to pin astropy because of warnings.

bhazelton commented 5 months ago

I re-ran until only the warnings tests were failing, then merged.