RadioAstronomySoftwareGroup / pyuvdata

A pythonic interface for radio astronomy interferometry data (uvfits, miriad, others)
https://pyuvdata.readthedocs.io/en/latest/index.html
BSD 2-Clause "Simplified" License
82 stars 27 forks source link

Break up long tests #1007

Open bhazelton opened 3 years ago

bhazelton commented 3 years ago

There are a number of really long tests in test_uvdata.py that really should be broken up, probably using the pytest's parametrize feature.

A non-exhaustive list identified in #967 includes: test_reorder_freqs test_sum_vis_errors test_flex_spw_add_concat test_break_add test_smart_slicing

kartographer commented 3 years ago

FWIW, I've gone through and cleaned up all but test_smart_slicing in #979, either because I was cleaning them up anyways (per a request from @plaplant to break up some monolithic tests), or because I was the one who originally wrote the ultra-long test (opps). But there are a few more that are fairly long -- choosing a fairly arbitrary cutoff of 150 lines of non-blank lines (excluding @pytest calls), where there's a bit of a break in the distribution of test lengths: