RadioAstronomySoftwareGroup / pyuvdata

A pythonic interface for radio astronomy interferometry data (uvfits, miriad, others)
https://pyuvdata.readthedocs.io/en/latest/index.html
BSD 2-Clause "Simplified" License
82 stars 25 forks source link

Add new metadata to UVCal and UVData objects to track the polarization normalization #1441

Open bhazelton opened 1 month ago

bhazelton commented 1 month ago

There are two potential approaches:

Note: we'd only do one of the above options, interested in community feedback about which one to implement.

When applying a calibration to a UVData object, if this metadata is set on the UVCal object it should be propagated to the calibrated UVData object.

jsdillon commented 1 month ago

This seems reasonable to me.

bhazelton commented 1 month ago

This seems reasonable to me.

@jsdillon Do you have a preference between the two options?

jsdillon commented 1 month ago

Sorry, I was confused. I thought the idea was to do both.

I think Option A feels more "right" to me, but I'm open to both. I don't feel like you have to do both.

rlbyrne commented 1 week ago

I prefer the first option, to keep vis_units a real unit. I think the second option could also get confusing because there is nothing in the parameter or value to connect "sum" and "average" to polarization.

jsdillon commented 4 days ago

We're looking to change over the HERA delay spectrum pipeline to the "sum" convetion and it'd be helpful to have this new optional parameter (which seems like the consensus) in place when we do that. Would it be possible to get this added this week?