Progbar update

[mkolopanis]

Keep writing progsteps to terminal after rank 0 finishes work

Description

Changed to a non-blocking barrier after the work execution loop. Registered a sys.stdout.close for non rank 0 processes. Newer openmpi versions complain about an open file handler. I could probably add a time.sleep() to the end of the loop for updating progess too, otherwise the rank 0 will just be writing a ton. maybe a few seconds?

Motivation and Context

closes #338 This only resolves the actual issue of the progsteps stopping writing. It does not address the delay we were investigating in that issue. I think we should probably make the delay thing a new issue anyway.

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Reference simulation update or replacement
• [ ] Documentation change (documentation changes only)
• [ ] Version change
• [ ] Build or continuous integration change

Checklist:

For all pull requests:

• [x] I have read the contribution guide.
• [x] My code follows the code style of this project.

Bug fix checklist:

• [ ] My fix includes a new test that breaks as a result of the bug (if possible).
• [x] All new and existing tests pass.
• [ ] I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
• [ ] I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
• [x] I have updated the CHANGELOG.

[codecov[bot]]

Codecov Report

Merging #345 (6a6ed67) into main (6971648) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   99.01%   99.02%           
=======================================
  Files          13       13           
  Lines        1931     1945   +14     
=======================================
+ Hits         1912     1926   +14     
  Misses         19       19           

Impacted Files	Coverage Δ
pyuvsim/mpi.py	100.00% <ø> (ø)
pyuvsim/uvsim.py	98.46% <100.00%> (+0.06%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6971648...6a6ed67. Read the comment docs.

[mkolopanis]

@aelanman what are your thoughts about adding a time.sleep to the end of the updating loop?

[aelanman]

It shouldn't be necessary for the progsteps, because it only prints when the counter value has stepped by 1% of the total number of tasks (or for every step if there are fewer than 100 tasks). However, it would reduce the number of calls to counter.current_value()... I'm not sure if having rank 0 constantly locking and unlocking the counter would slow down other processes.

[mkolopanis]

Are we interested in print statements to show time to complete some parts like these?

[aelanman]

That looks like a good idea. You should probably include " min" at the end of the format strings so the user knows the time is measured in minutes.

[mkolopanis]

Time is an astropy object (or subclass if from the moon repo right?) it should print out the units too.

[aelanman]

Oh right, of course. Looks good!

[mkolopanis]

@aelanman I think this is ready for another look.