RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.

https://pyuvsim.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

43 stars 7 forks source link

remove sleep from pbar update loop #347

Closed mkolopanis closed 3 years ago

mkolopanis commented 3 years ago

remove sleep introduced in last PR. Turns out it serializes the execution of the task loop, Ran reference sim 1.1 before and after this change and the before is very slow, but after completes in ~.03 minutes same as before last PR

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Reference simulation update or replacement
[ ] Documentation change (documentation changes only)
[ ] Version change
[ ] Build or continuous integration change

Checklist:

For all pull requests:

[x] I have read the contribution guide.
[x] My code follows the code style of this project.

codecov[bot] commented 3 years ago

Codecov Report

Merging #347 (a43e80e) into main (13bb52b) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   99.02%   99.02%   -0.01%     
==========================================
  Files          13       13              
  Lines        1945     1943       -2     
==========================================
- Hits         1926     1924       -2     
  Misses         19       19

Impacted Files	Coverage Δ
pyuvsim/uvsim.py	`98.45% <ø> (-0.01%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13bb52b...a43e80e. Read the comment docs.

mkolopanis commented 3 years ago

@bhazelton I think this will require admin to merge because I've removed covered lines, but I don't think it is reasonable to serialize a uvtask to once a second.

bhazelton commented 3 years ago

I don't think you do -- the test that's failing is not a required test for exactly this reason.

mkolopanis commented 3 years ago

Oh okay thanks! Always get scared at red x

On Tue, Apr 6, 2021, 16:33 Bryna Hazelton @.***> wrote:

I don't think you do -- the test that's failing is not a required tea for exactly this reason.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RadioAstronomySoftwareGroup/pyuvsim/pull/347#issuecomment-814498963, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACB7BLINGDQFOBNXYAVPWO3THOK23ANCNFSM42PUDA2Q .