Update Ntasks calc

[mkolopanis]

Sum all the task over each node to find total number of tasks.

Description

Changed the Ntasks_tot to multiply ntasks_local * nsky_parts then sum over each rank to get an accurate total number of tasks.

Motivation and Context

The number of reported tasks wasn't exactly accurate in all cases. Especially if one node had less RAM than others.

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Reference simulation update or replacement
• [ ] Documentation change (documentation changes only)
• [ ] Version change
• [ ] Build or continuous integration change

Checklist:

For all pull requests:

• [x] I have read the contribution guide.
• [x] My code follows the code style of this project.

Bug fix checklist:

• [ ] My fix includes a new test that breaks as a result of the bug (if possible).
• [x] All new and existing tests pass.
• [ ] I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
• [ ] I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
• [ ] I have updated the CHANGELOG.

New feature checklist:

• [ ] I have added or updated the docstrings associated with my feature using the numpy docstring format.
• [ ] I have updated the documentation to highlight my new feature (if appropriate).
• [ ] I have added tests to cover my new feature.
• [ ] All new and existing tests pass.
• [ ] I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
• [ ] I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
• [ ] I have updated the CHANGELOG.

Breaking change checklist:

• [ ] I have updated the docstrings associated with my change using the numpy docstring format.
• [ ] I have updated the documentation to reflect my changes (if appropriate).
• [ ] My change includes backwards compatibility and deprecation warnings (if possible).
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests pass.
• [ ] I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
• [ ] I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
• [ ] I have updated the CHANGELOG.

Reference simulation update or replacement:

• [ ] If this is a new reference simulation or if the settings files have changed, I have added all the relevant files to the reference_simulations folder.
• [ ] If this is a new reference simulation I have fully documented it in a memo in docs and updated any other docs as appropriate.
• [ ] I have updated the CHANGELOG.

Documentation change checklist:

• [ ] Any updated docstrings use the numpy docstring format.
• [ ] If this is a significant change to the readme or other docs, I have checked that they are rendered properly on ReadTheDocs. (you may need help to get this branch to build on RTD, just ask!)

Version change checklist:

• [ ] I have updated the CHANGELOG to put all the unreleased changes under the new version (leaving the unreleased section empty).
• [ ] I have run the appropriate tests for this level of version change (described in the readme under versioning).

Build or continuous integration change checklist:

• [ ] If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
• [ ] If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

[codecov[bot]]

Codecov Report

Merging #349 (6bf8d92) into main (d63a968) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          13       13           
  Lines        1943     1945    +2     
=======================================
+ Hits         1924     1926    +2     
  Misses         19       19           

Impacted Files	Coverage Δ
pyuvsim/uvsim.py	98.46% <100.00%> (+<0.01%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d63a968...6bf8d92. Read the comment docs.

[mkolopanis]

the rtd build seems to have given up the last few pushes (excessive memory), but I don't seem to be able to restart it.

[mkolopanis]

@bhazelton any ideas about the RTD? I know you have done some work with the out of memory issues before. What I really don't understand is why this PR is different from #352 and #350 in terms of rtd. Neither of those had build trouble :thinking:

[bhazelton]

I'm not sure what the issue was, but I just re-ran it and it worked. I did notice that the python version is pinned to 3.6 in ci/rtd_env.yml, which isn't great. I think we should change it to at least 3.7 (or 3.8 so it'll last longer).

[bhazelton]

@aelanman can you re-approve?