RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Propagate Clobber to skyh5 and uvh5 #351

Closed mkolopanis closed 3 years ago

mkolopanis commented 3 years ago

fixes #340 propagates the clobber keyword from pyradiosky into some tests that call write_skyh5 requires RadioAstronomySoftwareGroup/pyradiosky#144

codecov[bot] commented 3 years ago

Codecov Report

Merging #351 (e75dc22) into main (630cb43) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          13       13           
  Lines        1945     1945           
=======================================
  Hits         1926     1926           
  Misses         19       19           
Impacted Files Coverage Δ
pyuvsim/utils.py 97.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 630cb43...e75dc22. Read the comment docs.

mkolopanis commented 3 years ago

I think I ended up smashing two things together in my head for this because of the word "clobber". Clobber was added to skyh5 writer and needed to be updated in the tests here (since there's some on the fly catalog writing? ) but also that the uvh5 writer did not propagate whatever clobber keyword was being sent to the UVData writer.

but yes the code/tests are changing different things, which seems confusing because there's normally tests to test all the code changes. Hmm we do have a test where we write to each of the formats supported but do not try to overwrite them. we could do that if we want to add a test explicitly for this clobbering?

bhazelton commented 3 years ago

I think it'd be good to have at least one test that checks that the clobber keyword is passed to the UVData write method(s) properly, especially since it's going through the param_dict mechanism.

mkolopanis commented 3 years ago

Sounds good I'll get that done. Sorry for the confusion with doing two things!