RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.

https://pyuvsim.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

43 stars 7 forks source link

update RTD build to use python 3.8, fix errors and warnings from new pyuvdata/pyradiosky versions #353

Closed bhazelton closed 3 years ago

bhazelton commented 3 years ago

Description

Update the RTD build yamls to ensure we build against python 3.8 rather than 3.6 (which is no longer supported by pyuvdata).

Also fixed a few new errors from a new pyuvdata version and a bunch of warnings that have been around for a while (including some numpy and pyradiosky deprecation warnings).

Motivation and Context

This may or may not help with intermittent memory issues on the RTD build. Python 3.6 is no longer supported by pyuvdata, so using it results in using an old version of pyuvdata which is not ideal.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Reference simulation update or replacement
[x] Documentation change (documentation changes only)
[ ] Version change
[x] Build or continuous integration change

Checklist:

For all pull requests:

[x] I have read the contribution guide.
[x] My code follows the code style of this project.

Documentation change checklist:

[ ] Any updated docstrings use the numpy docstring format.
[x] If this is a significant change to the readme or other docs, I have checked that they are rendered properly on ReadTheDocs. (you may need help to get this branch to build on RTD, just ask!)

Build or continuous integration change checklist:

[ ] If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
[ ] If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

codecov[bot] commented 3 years ago

Codecov Report

Merging #353 (c3e9c20) into main (b857378) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files          13       13           
  Lines        1945     1945           
=======================================
  Hits         1926     1926           
  Misses         19       19

Impacted Files	Coverage Δ
pyuvsim/analyticbeam.py	`100.00% <100.00%> (ø)`
pyuvsim/antenna.py	`94.23% <100.00%> (ø)`
pyuvsim/mpi.py	`100.00% <100.00%> (ø)`
pyuvsim/simsetup.py	`99.88% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b857378...c3e9c20. Read the comment docs.

bhazelton commented 3 years ago

The test errors I fixed on this PR are breaking the pyradiosky external tests.