Add handling and checking for x_orientation

[bhazelton]

Description

Add a check on the x_orientation of the beams. If it is set consistently on all the beams, use it to set the output uvdata x_orientation. If it is inconsistent across the beams raise an error.

I also moved a function so that it was defined before it was called and I had to do a little refactoring to keep the complexity of create_mock_catalog under the limit.

Motivation and Context

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Reference simulation update or replacement
• [ ] Documentation change (documentation changes only)
• [ ] Version change
• [ ] Build or continuous integration change

Checklist:

For all pull requests:

• [x] I have read the contribution guide.
• [x] My code follows the code style of this project.

Bug fix checklist:

• [x] My fix includes a new test that breaks as a result of the bug (if possible).
• [x] All new and existing tests pass.
• [ ] I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
• [ ] I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
• [ ] I have updated the CHANGELOG.

[codecov[bot]]

Codecov Report

Merging #363 (af4f66d) into main (d5a8cf1) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   99.07%   99.08%   +0.01%     
==========================================
  Files          13       13              
  Lines        1941     1963      +22     
==========================================
+ Hits         1923     1945      +22     
  Misses         18       18              

Impacted Files	Coverage Δ
pyuvsim/simsetup.py	99.88% <100.00%> (+<0.01%)	:arrow_up:
pyuvsim/telescope.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a8cf1...af4f66d. Read the comment docs.

[bhazelton]

@steven-murray the hera_sim tests appear to be failing on this PR but I'm not sure it's caused by the changes in this PR. Can you investigate?

[bhazelton]

@steven-murray this PR is failing on the hera_sim tests because of a UVData select on polarization that is asking for the "ee" polarization but it looks like the UVData object doesn't have x_orientation set. I don't really see why this should have been affected by this PR, can you take a look?

[steven-murray]

Ah. I'll look into it more, but I think this is something that will be dealt with properly in the upcoming simulator overhaul for hera_sim. At the moment, polarization for VisCPU is just broken on the main branch.

[bhazelton]

@aelanman can you re-approve this so I can merge it?