RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Update Reference Sim Doc #364

Closed mkolopanis closed 3 years ago

mkolopanis commented 3 years ago

closes #362

Description

Adds an optional argument to download_latest_data.py to get the uvbeam and two healpix skymodels from the google drive. also adds a direct link to the google drive for users.

Checklist:

For all pull requests:

codecov[bot] commented 3 years ago

Codecov Report

Merging #364 (9f0711a) into main (d5a8cf1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          13       13           
  Lines        1941     1941           
=======================================
  Hits         1923     1923           
  Misses         18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a8cf1...9f0711a. Read the comment docs.

bhazelton commented 3 years ago

@steven-murray The hera_sim errors are happening on this PR too, which just updates documentation.

mkolopanis commented 3 years ago

The error looks like there is no mpi installed, is hera_sim trying to call part of pyuvsim that needs mpi? maybe we need to update our herasim environment?

bhazelton commented 3 years ago

oh, maybe! I think there were other errors besides that on the other PR, but I didn't check this one closely.

steven-murray commented 3 years ago

Yup, looks like it's the MPI requirement. I wonder if it's possible to use hera_sim's own testing env instead of maintaining your own?

mkolopanis commented 3 years ago

just to be safe I rebased after the herasim update.