Closed bhazelton closed 2 years ago
Merging #375 (65bddc5) into main (d644607) will increase coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 99.09% 99.14% +0.05%
==========================================
Files 13 13
Lines 1980 1997 +17
==========================================
+ Hits 1962 1980 +18
+ Misses 18 17 -1
Impacted Files | Coverage Δ | |
---|---|---|
pyuvsim/antenna.py | 96.07% <100.00%> (+1.84%) |
:arrow_up: |
pyuvsim/simsetup.py | 99.88% <100.00%> (+<0.01%) |
:arrow_up: |
pyuvsim/utils.py | 98.10% <100.00%> (+0.12%) |
:arrow_up: |
pyuvsim/uvsim.py | 98.55% <100.00%> (+0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d644607...65bddc5. Read the comment docs.
There are some checkmarks in the PR template about reproducing the reference sims. I haven't done that yet, are there scripts for that?
I think we decided that it should not be necessary for complete reproduction of the reference sims for this PR. Maybe wouldn't hurt to run sim 2.1 though on a cluster? That one takes a few hours generally.
I think that would be more than sufficient and if you're willing, I'd be grateful. I was going to try to figure out how to run the v1 sims on my own machine but haven't had the time yet.
Yeah I'll run them and report back.
Reference sim 2.1 took 516.642 min, on par with the ~8.5ish hours we saw in the PR we just merged. I didn't think a comparison with main was strictly necessary since this PR has such quick turnaround with the blt ordering one.
@mkolopanis did you also check that it got the same results? If so, I think this might be ready for another review.
So this is a fun point. We don't have a saved reference sim 2.1 on the google drive. I can check that it matches some other reference sim 2.1 outputs.
But yes all the results match the previous simulations I have run for timings (including from the old main
branch). in that case. I agree ready for a review
@aelanman I think this PR is ready if you want to have another look.
Description
SkyModel.source_cuts
if they are available.Motivation and Context
Stay up to date with changes in pyuvdata & pyradiosky:
source_cuts
method on SkyModel (see https://github.com/RadioAstronomySoftwareGroup/pyradiosky/pull/161)Types of changes
Checklist:
For all pull requests:
Bug fix checklist:
New feature checklist: