Closed slosar closed 2 years ago
@slosar We fixed the problem that is leading to all these test failures on the main branch. If you rebase this branch on main it should fix the tests.
@slosar Actually, I'm wrong. We haven't quite merged it into main. Let us do that and then I'll tell you when it's ready to rebase.
@slosar Ok we have the fix for the failing tests merged in now. I'm happy to do the rebase for you if you'd prefer.
Ok, I tried (there were some weird git hiccups, hopefully nothing is broken afresh)
Merging #378 (201402f) into main (1f88b96) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #378 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 13 13
Lines 2054 2054
=======================================
Hits 2037 2037
Misses 17 17
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1f88b96...201402f. Read the comment docs.
@slosar I think you did a pull after your rebase so I think this will not be able to be merged in properly. Is it ok if I clean up the git history? If I do, you'll need to delete your local copy of the branch and check it out fresh when I'm done.
Ok, all I wanted to do is to change one line in README and things have go south badly. :) Can you clean up after me? Thanks.
Sorry about that @slosar! I think it's all straightened out now, so you should delete your local copy of the branch and check it out fresh.
I hope this is now all fixed.
Minor tweaks to readme and download scripts as per slack discussion.
Description
Three changes:
download_gleam.py
spits out a deprecated message and points user to pyradioskyreference_simulations/second_generation/catalog_files/gleam.vot
points to../first_generation/catalog-files/gleam.vot
(which, however still needs to be downloaded)Types of changes
Checklist:
For all pull requests: