RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Add option for keeping the stdout for nonzero rank processing units #387

Closed bhazelton closed 2 years ago

bhazelton commented 2 years ago

Description

Add an option to the run_param_pyuvsim.py script and the run_uvsim and run_uvdata_uvsim functions to allow users to keep the output from nonzero ranks for debugging purposes.

Also did some CI & testing updates now that the new version of pyradiosky is out. Biggest change is to add a new CI job that runs the tests using the minimum required versions of pyuvdata and pyradiosky to ensure those versions work. This exposed some bugs that I also fixed. I also removed some "pragma: no cover" markings for code that runs under the newest version of pyradiosky and added tests to cover some newly exposed lines.

Motivation and Context

By default, output from nonzero ranks is surpassed (set to /dev/null). This adds an option, useful for debugging purposes, to keep that output.

Types of changes

Checklist:

For all pull requests:

New feature checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #387 (efadecf) into main (62e8943) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   99.32%   99.33%           
=======================================
  Files          13       13           
  Lines        2067     2094   +27     
=======================================
+ Hits         2053     2080   +27     
  Misses         14       14           
Impacted Files Coverage Δ
pyuvsim/mpi.py 100.00% <ø> (ø)
pyuvsim/simsetup.py 99.89% <100.00%> (+<0.01%) :arrow_up:
pyuvsim/uvsim.py 99.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62e8943...efadecf. Read the comment docs.