RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Add return options to `initialize_uvdata_from_params` and `initialize_catalog_from_params` #390

Closed bhazelton closed 2 years ago

bhazelton commented 2 years ago

Description

Motivation and Context

closes #215

Types of changes

Checklist:

For all pull requests:

New feature checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #390 (43d51b3) into main (2d01e1d) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   99.33%   99.34%           
=======================================
  Files          13       13           
  Lines        2094     2124   +30     
=======================================
+ Hits         2080     2110   +30     
  Misses         14       14           
Impacted Files Coverage Δ
pyuvsim/simsetup.py 99.89% <100.00%> (+<0.01%) :arrow_up:
pyuvsim/uvsim.py 99.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d01e1d...43d51b3. Read the comment docs.

bhazelton commented 2 years ago

@steven-murray This PR addresses an issue you made some time ago. Can you take a look?

bhazelton commented 2 years ago

@steven-murray I just updated the changelog and docs, can you re-review?