Closed bhazelton closed 2 years ago
Merging #392 (ce70893) into main (2193fd3) will increase coverage by
22.77%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #392 +/- ##
===========================================
+ Coverage 76.55% 99.33% +22.77%
===========================================
Files 13 13
Lines 2094 2094
===========================================
+ Hits 1603 2080 +477
+ Misses 491 14 -477
Impacted Files | Coverage Δ | |
---|---|---|
pyuvsim/telescope.py | 100.00% <0.00%> (+4.84%) |
:arrow_up: |
pyuvsim/astropy_interface.py | 100.00% <0.00%> (+7.14%) |
:arrow_up: |
pyuvsim/simsetup.py | 99.89% <0.00%> (+8.78%) |
:arrow_up: |
pyuvsim/utils.py | 98.11% <0.00%> (+25.78%) |
:arrow_up: |
pyuvsim/uvsim.py | 99.42% <0.00%> (+38.39%) |
:arrow_up: |
pyuvsim/profiling.py | 97.72% <0.00%> (+56.81%) |
:arrow_up: |
pyuvsim/mpi.py | 100.00% <0.00%> (+95.33%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2193fd3...ce70893. Read the comment docs.
The hera_sim tests fail because there are multiple HERA packages that have URLs in their requirements that start with "git://". I initially thought it was caused by those kind of URLs in hera_sim's setup.cfg, which are a problem but are not actually causing these test failures because we use the --no-deps
flag when installing hera_sim. Looks like it's caused by hera_cal and probably other packages with those kinds of dependencies.
I made an issue about that here: https://github.com/HERA-Team/hera_sim/issues/219
I made an issue for this on hera_cal here: https://github.com/HERA-Team/hera_cal/issues/766
The project level coverage drop will be fixed in #387
Description
Fix urls in pre-commit and conda yamls to use https rather than git
Also updated the pre-commit package versions.
Motivation and Context
GitHub no longer allows URLs starting with "git" rather than "ssh" or "https".
Types of changes
Checklist:
For all pull requests:
Build or continuous integration change checklist: