search

RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

generalizing jones matrix for Nfeeds=1,2 #394

Open slosar opened 2 years ago

slosar commented 2 years ago

Changes the jones matrix routine to (Nfeeds,2) instead of (2,2) generalizing to any Nfeeds. Down the line Nfeeds can still be only 1 or 2, but this can be changed. This is only a proposal.

Description

See file changes - pretty obvious. Still specialized for theta-phi coordinate system.

codecov[bot] commented 2 years ago

Codecov Report

Merging #394 (c28cf25) into main (8092079) will decrease coverage by 0.04%. The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
- Coverage   99.34%   99.29%   -0.05%     
==========================================
  Files          13       13              
  Lines        2126     2130       +4     
==========================================
+ Hits         2112     2115       +3     
- Misses         14       15       +1
Impacted Files Coverage Δ
pyuvsim/uvsim.py 99.15% <83.33%> (-0.28%) :arrow_down:
pyuvsim/antenna.py 96.07% <100.00%> (-0.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8092079...c28cf25. Read the comment docs.