RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Properly handle UVBeams with E-field components not aligned with azimuth & zenith angle #395

Open bhazelton opened 2 years ago

bhazelton commented 2 years ago

The code that takes the UVBeam data array into the jones matrix (in antenna.py) assumes a beam that has E-field components aligned with the azimuth and zenith angle axes. This should not be assumed, instead we need to use the basis_vector_array on UVBeam objects to get the mapping to azimuth/zenith angle aligned vectors.