RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Fix test to allow MPI greater than 3 #396

Closed bhazelton closed 2 years ago

bhazelton commented 2 years ago

Description

Change the MPI version test to check that the MPI version is greater than or equal to 3 rather than exactly 3.

Motivation and Context

Now that MPI 4 is out and is being picked up by CI runs, this is causing errors (e.g. in pyradiosky's external tests).

Types of changes

Checklist:

For all pull requests:

Bug fix checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #396 (7742278) into main (8092079) will decrease coverage by 1.22%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   99.34%   98.11%   -1.23%     
==========================================
  Files          13       13              
  Lines        2126     2126              
==========================================
- Hits         2112     2086      -26     
- Misses         14       40      +26     
Impacted Files Coverage Δ
pyuvsim/astropy_interface.py 42.85% <0.00%> (-57.15%) :arrow_down:
pyuvsim/profiling.py 88.63% <0.00%> (-9.10%) :arrow_down:
pyuvsim/uvsim.py 98.28% <0.00%> (-1.15%) :arrow_down:
pyuvsim/simsetup.py 98.84% <0.00%> (-1.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8092079...7742278. Read the comment docs.