Closed bhazelton closed 2 years ago
Merging #404 (fa185e6) into main (d5ae72b) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #404 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 13 13
Lines 2131 2141 +10
=======================================
+ Hits 2117 2127 +10
Misses 14 14
Impacted Files | Coverage Δ | |
---|---|---|
pyuvsim/simsetup.py | 99.89% <ø> (-0.01%) |
:arrow_down: |
pyuvsim/analyticbeam.py | 100.00% <100.00%> (ø) |
|
pyuvsim/antenna.py | 96.15% <100.00%> (ø) |
|
pyuvsim/telescope.py | 100.00% <100.00%> (ø) |
|
pyuvsim/utils.py | 98.10% <100.00%> (-0.07%) |
:arrow_down: |
pyuvsim/uvsim.py | 99.43% <100.00%> (+<0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d5ae72b...fa185e6. Read the comment docs.
@steven-murray I think I addressed your comments, but now the hera_sim tests are failing and I don't understand why. The error message is
TypeError: interp() got an unexpected keyword argument 'check_azza_domain'
Which should not be happening because the pyuvdata version is 2.2.8, which includes the change.
Description
This adds a parameter to
run_uvsim
andrun_uvdata_uvsim
to allow for the check that the beam covers the interpolation location to be turned off. The default behavior is to turn off the check if the beam covers the full sky horizon to horizon.Turning off this check can lead to substantial speedups, but if sources are simulated outside the beam area the response will be incorrect.
This requires updating out pyuvdata requirement to >= 2.2.8 when the
check_azza_domain
parameter was added toUVBeam.interp
. I don't see a downside to updating this requirement.Motivation and Context
closes #388
Types of changes
Checklist:
For all pull requests:
New feature checklist: