RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Check that beam basis vectors are aligned with the azimuth and zenith angle #405

Closed bhazelton closed 2 years ago

bhazelton commented 2 years ago

Description

This adds a check that the beam basis vectors are aligned with the azimuth and zenith angle in each pixel. This is currently assumed but not checked in pyuvsim.

Motivation and Context

In the future we'd like to properly support other basis vectors (#395), but this ensures that we at least test for this and error if it's not the case.

Types of changes

Checklist:

For all pull requests:

Bug fix checklist:

codecov[bot] commented 2 years ago

Codecov Report

Merging #405 (9d059dc) into main (c79535b) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   99.34%   99.35%           
=======================================
  Files          13       13           
  Lines        2141     2157   +16     
=======================================
+ Hits         2127     2143   +16     
  Misses         14       14           
Impacted Files Coverage Δ
pyuvsim/telescope.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c79535b...9d059dc. Read the comment docs.