Closed bhazelton closed 1 year ago
Base: 99.48% // Head: 99.13% // Decreases project coverage by -0.36%
:warning:
Coverage data is based on head (
41a11ed
) compared to base (254215d
). Patch coverage: 92.50% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The missing coverage in antenna.py
& simsetup.py
will be fixed when the next pyuvdata version is released.
@bhazelton should I wait until that version is out before re-reviewing?
@steven-murray no, I'd rather not because then we'll have a period, even if it's short, where pyuvsim doesn't work with the newest pyuvdata. I could add pragmas to exclude those lines from coverage, but it feels a bit silly. I'd rather just take the coverage hit for a little while. This PR explicitly works with both the older and the newer versions, it's just that code specific to the newer versions isn't being hit because we install pyuvdata from conda not from the repo.
Description
Fix various tests that were broken by recent changes in pyuvdata and new astropy deprecation warnings.
Also fixes some things that will break with some upcoming pyuvdata PRs.
Motivation and Context
Types of changes
Checklist:
For all pull requests:
Bug fix checklist: