Compatibility with pyradiosky>=0.2

bhazelton commented 1 year ago

Description

Mostly this required changing over to the new skycoord parameter on SkyModel objects. I decided to just make a clean break and require pyradiosky>=0.2 because it made the code much cleaner. In order to make this work with pyradiosky v0.3, I had to remove some code that called functions/options in pyradiosky that were removed in v0.3. I think we should bump the version of pyuvsim to v1.3 when we merge this PR because of those changes.

Note: there is one change in pyradiosky that required updating some test files: pyradiosky now interprets J2000 in text file and votable (e.g. Gleam) catalog column headings as implying that the coordinate frame is FK5 rather than ICRS (as it used to). This is more correct but it could lead to small changes compared to previous pyuvsim runs. This needs some careful testing.

I also had to improve the lunarsky importing structure to match pyuvdata and pyradiosky -- this is required because it caused errors related to the mismatch between pyuvsim and the newest pyradiosky.

This also increased the version of lunarsky to get rid of astropy deprecation warnings that were cropping up.

Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Reference simulation update or replacement
[ ] Documentation change (documentation changes only)
[ ] Version change
[ ] Build or continuous integration change

Checklist:

For all pull requests:

[x] I have read the contribution guide.
[x] My code follows the code style of this project.

Bug fix checklist:

[x] My fix includes a new test that breaks as a result of the bug (if possible).
[x] All new and existing tests pass.
[ ] I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
[ ] I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
[x] I have updated the CHANGELOG.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.25 :tada:

Comparison is base (cbcc151) 99.20% compared to head (d173e99) 99.45%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #417 +/- ## ========================================== + Coverage 99.20% 99.45% +0.25% ========================================== Files 13 12 -1 Lines 2256 2201 -55 ========================================== - Hits 2238 2189 -49 + Misses 18 12 -6 ``` | [Impacted Files](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup) | Coverage Δ | | |---|---|---| | [pyuvsim/simsetup.py](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHl1dnNpbS9zaW1zZXR1cC5weQ==) | `99.89% <100.00%> (+0.48%)` | :arrow_up: | | [pyuvsim/telescope.py](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHl1dnNpbS90ZWxlc2NvcGUucHk=) | `100.00% <100.00%> (ø)` | | | [pyuvsim/uvsim.py](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHl1dnNpbS91dnNpbS5weQ==) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/417/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bhazelton commented 1 year ago

@steven-murray heads-up, the hera_sim tests are failing on this PR.

steven-murray commented 1 year ago

@bhazelton I think Bobby has fixes for this in https://github.com/HERA-Team/hera_sim/pull/248

RadioAstronomySoftwareGroup / pyuvsim