RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Fix Nsky parts bug #424

Closed bhazelton closed 1 year ago

bhazelton commented 1 year ago

Description

This fixes a major bug that was introduced between v1.2.1 and v1.2.2. It affects runs where the source list is large enough that it is broken across more than one processing unit.

I also had to pin pyuvdata to less than v2.3 because of our current pinning of pyradiosky.

Motivation and Context

Types of changes

Checklist:

For all pull requests:

Bug fix checklist:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 96.15% and project coverage change: +0.04 :tada:

Comparison is base (1c4d6e2) 99.15% compared to head (ddda198) 99.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #424 +/- ## ========================================== + Coverage 99.15% 99.20% +0.04% ========================================== Files 13 13 Lines 2241 2256 +15 ========================================== + Hits 2222 2238 +16 + Misses 19 18 -1 ``` | [Impacted Files](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup) | Coverage Δ | | |---|---|---| | [pyuvsim/\_\_init\_\_.py](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHl1dnNpbS9fX2luaXRfXy5weQ==) | `84.21% <66.66%> (+2.96%)` | :arrow_up: | | [pyuvsim/analyticbeam.py](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHl1dnNpbS9hbmFseXRpY2JlYW0ucHk=) | `100.00% <100.00%> (ø)` | | | [pyuvsim/uvsim.py](https://codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHl1dnNpbS91dnNpbS5weQ==) | `100.00% <100.00%> (+0.27%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.