Prepare version 1.2.6 - Githubissues

RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.

https://pyuvsim.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

42 stars 6 forks source link

Prepare version 1.2.6 #429

Closed bhazelton closed 12 months ago

bhazelton commented 1 year ago

Description

Update the changelog for v1.2.6
minor CI updates

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Reference simulation update or replacement
[ ] Documentation change (documentation changes only)
[x] Version change
[x] Build or continuous integration change

Checklist:

For all pull requests:

[x] I have read the contribution guide.
[x] My code follows the code style of this project.

Version change checklist:

[x] I have updated the CHANGELOG to put all the unreleased changes under the new version (leaving the unreleased section empty).
[x] I have run the appropriate tests for this level of version change (described in the readme under versioning).

Build or continuous integration change checklist:

[ ] If required or optional dependencies have changed (including version numbers), I have updated the readme to reflect this.
[ ] If this is a new CI setup, I have added the associated badge to the readme and to references/make_index.py (if appropriate).

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.31 :tada:

Comparison is base (b48b36f) 99.18% compared to head (158858c) 99.49%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #429 +/- ## ========================================== + Coverage 99.18% 99.49% +0.31% ========================================== Files 12 12 Lines 2198 2198 ========================================== + Hits 2180 2187 +7 + Misses 18 11 -7 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/429/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bhazelton commented 1 year ago

The warnings test is broken because of pyuvdata-sourced numpy deprecation warnings. Those are fixed in pyuvdata 2.4, but I'm still fighting with conda-forge, so that version isn't on conda yet. I actually tried to move the warnings test to just build of pypi, which I still want to do to diversify our testing environments, but there seems to be something broken with the pypi mpi4py wheels, so I couldn't get that to work.

However, our warnings tests are not required to pass to merge and I think the HERA team really need this new version out. I'll note that there are no deprecation warnings when I run with pyuvdata 2.4 on my machine.