Fixes to prevent errors with pyuvdata 3.0

bhazelton commented 1 year ago

Description

Motivation and Context

Fixes a few things that will error in the future.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Reference simulation update or replacement
[ ] Documentation change (documentation changes only)
[ ] Version change
[ ] Build or continuous integration change

Checklist:

For all pull requests:

[x] I have read the contribution guide.
[x] My code follows the code style of this project.

Bug fix checklist:

[ ] My fix includes a new test that breaks as a result of the bug (if possible).
[x] All new and existing tests pass.
[ ] I have checked that I reproduce the reference simulations or if there are differences they are explained below (if appropriate). If there are changes that are correct, I will update the reference simulation files after this PR is merged.
[ ] I have checked (e.g., using the benchmarking tools) that this change does not significantly increase typical runtimes. If it does, I have included a justification in the comments on this PR.
[ ] I have updated the CHANGELOG.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d5e97cb) 99.49% compared to head (3390814) 99.49%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #432 +/- ## ======================================= Coverage 99.49% 99.49% ======================================= Files 12 12 Lines 2198 2199 +1 ======================================= + Hits 2187 2188 +1 Misses 11 11 ``` | [Files Changed](https://app.codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup) | Coverage Δ | | |---|---|---| | [pyuvsim/simsetup.py](https://app.codecov.io/gh/RadioAstronomySoftwareGroup/pyuvsim/pull/432?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RadioAstronomySoftwareGroup#diff-cHl1dnNpbS9zaW1zZXR1cC5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.

mkolopanis commented 1 year ago

weird that herasim failed on push but not PR

RadioAstronomySoftwareGroup / pyuvsim