RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
42 stars 7 forks source link

Make handling of `freq_interp_kind` flexible for future pyuvdata changes #442

Closed bhazelton closed 10 months ago

bhazelton commented 10 months ago

Description

This fixes some things that break in a pending pyuvdata PR (https://github.com/RadioAstronomySoftwareGroup/pyuvdata/pull/1378).

For now, this just makes sure we track freq_interp_kind on the BeamList object and either set it on the object or pass it to the interp functions depending on the version of pyuvdata (assessed by whether the attribute exists on UVBeam).

Long term, once we require a version of pyuvdata that doesn't have it as an attribute, I think we can entirely remove the uvb_params handling in telescope.py which will clean up that code substantially.

Motivation and Context

Types of changes

Checklist:

For all pull requests:

Bug fix checklist:

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5bc255a) 99.49% compared to head (b20be8b) 99.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #442 +/- ## ======================================= Coverage 99.49% 99.50% ======================================= Files 12 12 Lines 2199 2210 +11 ======================================= + Hits 2188 2199 +11 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.