Closed bhazelton closed 5 months ago
I think it would be nicer for the beam definitions in the YAML to have a nicer YAML tag, or at least to be more consistent.
I agree with you on this, but we'll have to go through a deprecation process and I'm pretty sure this will trip up on our reference sims. I'm happy to start the deprecation process by putting in the appropriate warnings now.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
92ab9e9
) 99.50% compared to head (abd1ac9
) 99.50%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hmmm, let's just make an issue and merge this branch, because I think the process of deprecation should be handled carefully.
Description
Support all UVBeam readable files. This required adding support for parameters to pass the to UVBeam.read method.
Motivation and Context
fixes #335
Types of changes
Checklist:
For all pull requests:
New feature checklist: