RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
42 stars 6 forks source link

Add support for all UVBeam files #444

Closed bhazelton closed 5 months ago

bhazelton commented 5 months ago

Description

Support all UVBeam readable files. This required adding support for parameters to pass the to UVBeam.read method.

Motivation and Context

fixes #335

Types of changes

Checklist:

For all pull requests:

New feature checklist:

bhazelton commented 5 months ago

I think it would be nicer for the beam definitions in the YAML to have a nicer YAML tag, or at least to be more consistent.

I agree with you on this, but we'll have to go through a deprecation process and I'm pretty sure this will trip up on our reference sims. I'm happy to start the deprecation process by putting in the appropriate warnings now.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (92ab9e9) 99.50% compared to head (abd1ac9) 99.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #444 +/- ## ======================================= Coverage 99.50% 99.50% ======================================= Files 12 12 Lines 2208 2240 +32 ======================================= + Hits 2197 2229 +32 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

steven-murray commented 5 months ago

Hmmm, let's just make an issue and merge this branch, because I think the process of deprecation should be handled carefully.