Prepare for v1.3 - Githubissues

RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.

https://pyuvsim.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

42 stars 6 forks source link

Prepare for v1.3 #457

Closed bhazelton closed 3 months ago

bhazelton commented 3 months ago

Update the changelog for the new version.

Also fix incorrect old release dates and handle an intermittent error in tests.

Description

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Reference simulation update or replacement
[ ] Documentation change (documentation changes only)
[x] Version change
[ ] Build or continuous integration change

Checklist:

For all pull requests:

[x] I have read the contribution guide.
[x] My code follows the code style of this project.

Version change checklist:

[x] I have updated the CHANGELOG to put all the unreleased changes under the new version (leaving the unreleased section empty).
[ ] I have run the appropriate tests for this level of version change (described in the readme under versioning).

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.95%. Comparing base (1b002c2) to head (f220879).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #457 +/- ## ======================================= Coverage 99.95% 99.95% ======================================= Files 12 12 Lines 2161 2161 ======================================= Hits 2160 2160 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bhazelton commented 3 months ago

Yeah, it's flaky. I don't understand why, it may be a downloading thing but the error is not clearly caused by that. @aelanman may have more info. We've done some of this kind of handling for these errors and JPL errors on pyuvdata.

aelanman commented 3 months ago

There's some intermittent error in how lunarsky defines and clears topocentric frames. I've managed to reproduce it, but haven't made much progress in fixing it. It should only be an issue in rare cases when you're generating and deleting lots of LunarTopo instances, so I think it's fine for this release. If we're really worried, maybe we can add a warning about flakiness?

jpober commented 3 months ago

Worried is a strong word, but it might be nice if there's a way to warn that this test was skipped. If that isn't feasible, I'll go ahead and approve and merge.

bhazelton commented 3 months ago

I don't know of a way to surface that up to a comment on the PR other than letting the test fail. But you can look at the CI logs in detail to see if tests were skipped. I agree it's not ideal to skip them but my experience is that usually at most 2 of the CI runs have this problem and it usually goes away if I re-run them.