RadioAstronomySoftwareGroup / pyuvsim

A ultra-high precision package for simulating radio interferometers in python on compute clusters.
https://pyuvsim.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Fix compatibility with pyuvdata v3.0, use UVData.new #465

Closed bhazelton closed 4 months ago

bhazelton commented 4 months ago

Description

Fix some things that will break in pyuvdata v3.0, particularly related to the new handling of telescope metadata.

This includes moving to using UVData.new for initializing UVData objects, which changes the default conjugation convention from "ant2<ant1" to "ant1<ant2". So I added an option to set the conjugation convention in the parameter yaml files, which was requested in #334. This also naturally fixes #427.

This also fixes the version handling for editable installs. This was missed when we went to the src layout.

Fixes #427 Fixes #334

Motivation and Context

Types of changes

Checklist:

For all pull requests:

Bug fix checklist:

New feature checklist:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (1db5e89) to head (164676c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #465 +/- ## =========================================== + Coverage 99.95% 100.00% +0.04% =========================================== Files 12 11 -1 Lines 2161 2174 +13 =========================================== + Hits 2160 2174 +14 + Misses 1 0 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.